Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese Transration #114

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

hibira
Copy link
Contributor

@hibira hibira commented Dec 23, 2023

Issue #, if available:
Non

Description of changes:
A Japanese translation has been created.
A /ja/ folder was created under docs, a Japanese translation was added to it, and mkdocs.ja.yaml was added.
Also, mkdocs.yaml has been fixed so that language switching can be displayed.
Regarding deployment, English and Japanese are built respectively, and the results have been modified to be deployed (update docs-ci.yaml).

Operation check
I've confirmed that I can deploy (publish) to the github page of the forked repository.
Also, it has been confirmed that English and Japanese can be switched on the GitHub page of the forked repository.
I have verified the Japanese text and that the markdown is not broken.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Collaborator

@lewinkedrs lewinkedrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for your contribution

@lewinkedrs lewinkedrs merged commit 423740e into aws-observability:main Jan 10, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants