fix(go/eks): bump kubectlv34 to v2.2.1 to resolve build failure#1249
Merged
fix(go/eks): bump kubectlv34 to v2.2.1 to resolve build failure#1249
Conversation
kubectlv34 v2.0.0 has broken Go codegen referencing the removed awscdk.ResourceEnvironment type. v2.2.1 uses interfaces.ResourceEnvironment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #1234 by @guessi (Go EKS 1.34 upgrade).
kubectlv34/v2@v2.0.0has broken Go codegen that references the removedawscdk.ResourceEnvironmenttype, causing a build failure:v2.2.1fixes this by usinginterfaces.ResourceEnvironmentinstead.Changes
kubectlv34fromv2.0.0tov2.2.1in bothgo/eks/clusterandgo/eks/cluster-gravitongo mod tidyto update transitive depsTesting
go build ./...passes for both modulesgo test ./...passes for both modulesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.