Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added newrelic into hybrid dir #302

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

jcountsNR
Copy link
Contributor

Issue #, if available:

Description of changes:

cloned the newrelic test cron job and add-on into the hybrid folder.

Copy link
Contributor

@mikemcd3912 mikemcd3912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pods deploy and reach a ready state, tester complete successfully - LGTM

Additionally @jcountsNR I got the request today from my team to update the directory name to "eks-hybrid-nodes", so when your team updates your weekly version update workflow there may need to be a small change to the path of these files. Thanks!

Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @jcountsNR . @mikemcd3912 We can merge this and then we can update the directory. Good callout to update NR Pipeline.

@mikemcd3912 mikemcd3912 merged commit fe58851 into aws-samples:main Oct 18, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants