Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubecost 2.4.3 bump #317

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Conversation

jessegoodier
Copy link
Contributor

@jessegoodier jessegoodier commented Nov 19, 2024

Issue #, if available:

Description of changes:
Bump kubecost version from 2.1.0 to 2.4.3

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@elamaran11
Copy link
Contributor

Looks like your deployment kubecost-kubecost-cost-analyzer is failing.
Specifically, it looks like these pods are failing:

  • Pod: kubecost-kubecost-cost-analyzer-9bd649fc8-sm8b2.

Looks like your deployment kubecost-kubecost-grafana is failing.
Specifically, it looks like these pods are failing:

  • Pod: kubecost-kubecost-grafana-785474d96d-6pwf2.
  • Pod: kubecost-kubecost-grafana-785474d96d-6pwf2.

Looks like your deployment kubecost-kubecost-prometheus-server is failing.
Specifically, it looks like these pods are failing:

  • Pod: kubecost-kubecost-prometheus-server-8d786b88f-548mg.

@mikemcd3912
Copy link
Contributor

mikemcd3912 commented Nov 21, 2024

Hi,

The message from Ela was automated, but to add some context it appears a couple of the workloads are experiencing an image pull issue:

Workloads:
image

Events from the Grafana pod:
image

Events from the Prometheus Pod:
image

In addition, it appears the tester is completing successfully despite those two sections of the workload not being deployed properly, so we may want to expand the functional testing to cover those elements as well if possible

@jessegoodier
Copy link
Contributor Author

Thanks @elamaran11
Will fix and ping back here.

@elamaran11
Copy link
Contributor

Looks like your deployment kubecost-kubecost-grafana is failing.
Specifically, it looks like these pods are failing:

  • Pod: kubecost-kubecost-grafana-768f57849c-mn5b8.
  • Pod: kubecost-kubecost-grafana-768f57849c-mn5b8.

Looks like your deployment kubecost-kubecost-prometheus-server is failing.
Specifically, it looks like these pods are failing:

  • Pod: kubecost-kubecost-prometheus-server-c859f75f6-gdx85.

@jessegoodier jessegoodier changed the title kubecost 2.4.2 bump kubecost 2.4.3 bump Nov 26, 2024
@jessegoodier
Copy link
Contributor Author

2.4.3 should resolve the issues.

@elamaran11
Copy link
Contributor

Looks like your deployment kubecost-kubecost-cost-analyzer is failing.
Specifically, it looks like these pods are failing:

  • Pod: kubecost-kubecost-cost-analyzer-6fcb48d6bb-gzh4s.

@jessegoodier
Copy link
Contributor Author

Looks like your deployment kubecost-kubecost-cost-analyzer is failing. Specifically, it looks like these pods are failing:

  • Pod: kubecost-kubecost-cost-analyzer-6fcb48d6bb-gzh4s.

Is it possible to re-run the job? if prometheus is not up when cost-analyzer starts, it can restart once or twice.

Copy link
Contributor

@mikemcd3912 mikemcd3912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All pods reach a ready state and the testers complete successfully in our environments - LGTM

@mikemcd3912 mikemcd3912 merged commit e5fdcd5 into aws-samples:main Dec 2, 2024
1 check passed
@mikemcd3912
Copy link
Contributor

Thanks for the update @jessegoodier! That last message from Ela was automated but on my manual re-test everything worked great. We appreciate the help getting that working

@jessegoodier jessegoodier deleted the kubecost-bump-2.4.2 branch December 2, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants