-
Notifications
You must be signed in to change notification settings - Fork 229
Support entity for OTLP custom metrics #1529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7f0a8f8
to
5e1b3aa
Compare
This PR was marked stale due to lack of activity. |
…ervice is set by OTEL SDK (#1557)
This PR was marked stale due to lack of activity. |
…r sets the service name OTEL resource attribute (#1565)
This PR was marked stale due to lack of activity. |
… pod metadata in map (#1613)
410aa11
to
1310484
Compare
nathalapooja
approved these changes
Apr 9, 2025
mitali-salvi
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
To support the Explore related feature in CloudWatch, the CloudWatch Agent sends an "Entity", which includes relevant metadata to correlate metrics or logs between resources (e.g., an EKS cluster) and services (e.g., a Java application). When the CloudWatch Agent runs in a Kubernetes cluster, we need to collect the namespace, workload name, and node name to populate the "Entity".
However, we currently only get Kubernetes metadata when Application Signals is enabled. For OTLP custom metrics, if Application Signals isn't configured, then we don't have a way to fetch Kubernetes metadata. To achieve this, we must migrate the logic the Application Signals Processor uses to get Kuberbetes metadata to a global extension, which can be used by other pipelines.
Description of changes
Important
Co-PRs: amazon-contributing/opentelemetry-collector-contrib#291; aws-observability/helm-charts#171
translator/translate/otel
)extension/k8smetadata/translator.go
to reference the extension in translation.translators.Extensions.Set(k8smetadata.NewTranslator())
topipeline/host/translator.go
for OTLP pipeline in Kubernetes contexts.service/defaultcomponents/components.go
to include"k8smetadata"
.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Integration Tests
View Workflow Run #14350034749
Application Signals E2E Tests
View Workflow Run #14350034748
Manual Testing
Agent Logs
PMD
EMF
Requirements
Before commit the code, please do the following steps.
make fmt
andmake fmt-sh
make lint