Rework Actions to Run on Candidate Release Artifacts #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dricross
commented
Feb 12, 2025
Comment on lines
-95
to
-114
| -var="ssh_key_value=${{env.PRIVATE_KEY}}" \ | ||
| -var="github_test_repo=${{ inputs.test_repo_url }}" \ | ||
| -var="test_name=${{ matrix.arrays.os }}" \ | ||
| -var="cwa_github_sha=${{inputs.github_sha}}" \ | ||
| -var="install_agent=${{ matrix.arrays.installAgentCommand }}" \ | ||
| -var="github_test_repo_branch=${{inputs.test_repo_branch}}" \ | ||
| -var="ec2_instance_type=${{ matrix.arrays.instanceType }}" \ | ||
| -var="user=${{ matrix.arrays.username }}" \ | ||
| -var="agent_start=${{ matrix.arrays.agentStartCommand }}" \ | ||
| -var="ami=${{ matrix.arrays.ami }}" \ | ||
| -var="ca_cert_path=${{ matrix.arrays.caCertPath }}" \ | ||
| -var="arc=${{ matrix.arrays.arc }}" \ | ||
| -var="binary_name=${{ matrix.arrays.binaryName }}" \ | ||
| -var="ca_cert_path=${{ matrix.arrays.caCertPath }}" \ | ||
| -var="cwa_github_sha=${{inputs.build_id}}" \ | ||
| -var="ec2_instance_type=${{ matrix.arrays.instanceType }}" \ | ||
| -var="excluded_tests='${{ matrix.arrays.excludedTests }}'" \ | ||
| -var="github_test_repo=${{ inputs.test_repo_url }}" \ | ||
| -var="github_test_repo_branch=${{inputs.test_repo_branch}}" \ | ||
| -var="install_agent=${{ matrix.arrays.installAgentCommand }}" \ | ||
| -var="local_stack_host_name=${{ inputs.localstack_host }}" \ | ||
| -var="plugin_tests='${{ github.event.inputs.plugins }}'" \ | ||
| -var="region=${{ inputs.region }}" \ | ||
| -var="s3_bucket=${{ inputs.s3_integration_bucket }}" \ | ||
| -var="plugin_tests='${{ github.event.inputs.plugins }}'" \ | ||
| -var="excluded_tests='${{ matrix.arrays.excludedTests }}'" \ | ||
| -var="ssh_key_name=${{env.KEY_NAME}}" \ | ||
| -var="ssh_key_value=${{env.PRIVATE_KEY}}" \ | ||
| -var="test_dir=${{ matrix.arrays.test_dir }}" \ | ||
| -var="agent_start=${{ matrix.arrays.agentStartCommand }}"; then terraform destroy -var="region=${{ inputs.region }}" -var="ami=${{ matrix.arrays.ami }}" -auto-approve |
There was a problem hiding this comment.
this is all just alphabetizing/formatting
TravisStark
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
The CloudWatch Agent candidate release artifacts (which are the real artifacts that will released to the public via s3/ecr) are created outside of the standard GitHub workflow. We'd like to be able to run the integration tests on those artifacts prior to a public release.
Description of changes
Test Artifacts: generalization of the existingRun Integration Testsworkflow but can accept github SHA or candidate release build version number (e.g. 1.300052.0b1024). Notably does not have theCheckBuildArtifactsstep since that wouldn't apply for candidate release artifacts.Test Release Candidatewhich has the following major steps:Repackage: Repackage release candidate artifacts to match how theBuild Artifactsworkflow sets up the artifacts in preparation forRun Integration TestTest Artifacts: run integration tests on the repackaged candidate release artifactsRun Integration Testsworkflow:Test Artifactsas a reusable workflowTest Artifactsinstead nowset-outputsince it's deprecated: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/GitHub actions are restricted to 5 nested workflow calls which complicates some thing.
Build Test Artifactsalready makes agh workflowcall toRun Integration TestsTest Release Candidatemakes agh workflowcall toTest ArtifactsI am open to restructuring how some of these things are called. It might be desirable to be consistent and always do a
gh workflowcall toTest Artifactsbut that would require ditching theCheckBuildArtifactsstep after thegh workflowcall as part of theBuild Test Artifactsworkflow.I chose to repackage the existing release artifacts to mimic the format of
Build Test Artifactsso that there were no changes to the test repo. All the terraform scripts work exactly the same.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
gh workflow run "Test Release Candidate" --ref dricross/actions-rework -f build_id=1.300052.0b1024Build Test ArtifactsworkflowRequirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint