fix instance-types filter and update readmes #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwagner5
force-pushed
the
fix-instancetypes
branch
7 times, most recently
from
a13e30c to
1aba4fe
Compare
bwagner5
force-pushed
the
fix-instancetypes
branch
from
1aba4fe to
12196cb
Compare
bwagner5
force-pushed
the
fix-instancetypes
branch
from
43e5aeb to
5144d53
Compare
LikithaVemulapalli
approved these changes
Feb 14, 2025
| @@ -106,21 +106,21 @@ c6gn.16xlarge | |||
| c6in.16xlarge | |||
| c7gn.8xlarge | |||
| dl1.24xlarge | |||
| f2.48xlarge | |||
There was a problem hiding this comment.
qq: when do we usually update these instances, how frequently we need to update them? whenever we have new launches we need to include them in this code base? same with the prices below, how frequently we do update because I haven't seen these details been updated for a while..
There was a problem hiding this comment.
I only update them when I plan on doing a release. It's only demo stuff for the README. In real operation these are all pulled dynamically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.