Add docker-build target for controller build #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haouc
reviewed
Apr 11, 2024
Makefile
Outdated
| .PHONY: docker-buildx | ||
| docker-buildx: test | ||
| .PHONY: docker-buildx-and-test | ||
| docker-buildx-and-test: test |
There was a problem hiding this comment.
I think there is no need to create another target just for different name. Adding test to docker-buildx is fine for me.
jaydeokar
force-pushed
the
add_docker_build
branch
from
3f4e436 to
69d20b5
Compare
jaydeokar
force-pushed
the
add_docker_build
branch
from
10f5940 to
97fb32b
Compare
jaydeokar
commented
May 3, 2024
| @@ -1 +1 @@ | |||
| 1.22.2 | |||
| 1.22 | |||
There was a problem hiding this comment.
This pins the go-version to the latest golang language version i.e. v1.N instead of the patch version v1.N.P..
This makes sure we are always building image with the latest patch for the golang version and does not need regular updates to pick the right patch version.
jayanthvn
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
cleanup
Which issue does this PR fix:
N/A
What does this PR do / Why do we need it:
This adds a docker build target for internal build systems
If an issue # is not available please add steps to reproduce and the controller logs:
N/A
Testing done on this change:
Yes
Automation added to e2e:
N/A
Will this PR introduce any new dependencies?:
N/A
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
N/A
Does this PR introduce any user-facing change?:
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.