ignore host network pods in all endpoints #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haouc
force-pushed
the
main
branch
7 times, most recently
from
75db615 to
6ff6d2d
Compare
|
Let's add a simple test result with host networking pods matching ingress, egress and pod selector endpoint selectors.. |
jayanthvn
reviewed
Mar 17, 2024
pkg/resolvers/endpoints.go
Outdated
| @@ -491,3 +497,22 @@ func dedupPorts(policyPorts []policyinfo.Port) []policyinfo.Port { | |||
| } | |||
| return nil | |||
| } | |||
|
|
|||
| func (r *defaultEndpointsResolver) getPodList(ctx context.Context, opts client.ListOption) ([]corev1.Pod, error) { | |||
There was a problem hiding this comment.
Maybe to make this more clear, it can be getNonHostNetworkingPodList ?
haouc
force-pushed
the
main
branch
2 times, most recently
from
96aae91 to
35c65f7
Compare
The results doc has been shared offline. Please let me know if we want to add the result here as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
Which issue does this PR fix:
We shouldn't populate pods in host network to PolicyEndpoint's endpoints.
What does this PR do / Why do we need it:
The endpoints from host network pods in ingress/egress/podselector can become redundant data in nodes and CRs.
If an issue # is not available please add steps to reproduce and the controller logs:
Testing done on this change:
Tested in local dev cluster and cyclonus tests were passed.
Automation added to e2e:
Will this PR introduce any new dependencies?:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.