chore(duvet): modernize duvet #500
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
texastony
commented
Jan 30, 2026
texastony
commented
- chore: use HTTPS for spec
- remove spec
- duvet: point specification to private
- chore(duvet): modernize duvet
… collision check - Split isV1V2InObjectMetadata() into separate isV1InObjectMetadata() and isV2InObjectMetadata() methods that properly check for version-exclusive keys - Add hasExclusiveKeyCollision() to detect when multiple version-exclusive keys (x-amz-key, x-amz-key-v2, x-amz-3) are present in metadata - Update decode() to throw exception when exclusive key collision is detected (requirement 106) - Fix Duvet annotations for requirements 102, 103, 104, and 106 - Update tests to use new version detection methods
…ag length bug - Add annotation for V1 format exclusive key requirement in MetadataKeyConstants - Fix bug: tag length was incorrectly written for CBC (should only be for GCM) - Add annotations for both GCM and CBC tag length requirements in ContentMetadataEncodingStrategy
Add Duvet annotation for requirement: 'If a mapkey exclusive to other (non-V3) format versions is present, the S3EC SHOULD throw an exception.' Implementation: MetadataKeyConstants.isV3Format() checks that V1/V2 keys are not present when validating V3 format at ContentMetadataDecodingStrategy line 92. Test coverage: Existing testExclusiveKeysCollision validates exception is thrown for conflicting version keys.
…ement Add Duvet annotations for requirement: 'The mapkey "x-amz-unencrypted-content-length" SHOULD be present for V2 format objects.' Annotations marked as type=exception since the implementation does not write or check this field for V2 objects. Locations: - ContentMetadataDecodingStrategy line 277-279 (V2 decoding) - ContentMetadataEncodingStrategy line 228-230 (V2 encoding) Test coverage: Existing V2 format tests validate decoding without this field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.