feat(cli): add --yes flag #826

ren-yamanashi · 2025-08-29T13:30:11Z

Fixes #732

Added --yes cli option so that if true, the command is always executed without confirmation.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…e behavior

codecov-commenter · 2025-08-30T02:38:15Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.57%. Comparing base (a890d3f) to head (cf7a224).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #826      +/-   ##
==========================================
+ Coverage   82.92%   83.57%   +0.65%     
==========================================
  Files          65       65              
  Lines        9528     9546      +18     
  Branches     1120     1141      +21     
==========================================
+ Hits         7901     7978      +77     
+ Misses       1605     1543      -62     
- Partials       22       25       +3

Flag	Coverage Δ
suite.unit	`83.57% <100.00%> (+0.65%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

… test non-interactive mode

…irmation prompts

ren-yamanashi · 2025-08-30T03:20:35Z

packages/aws-cdk/lib/cli/io-host/cli-io-host.ts

+      // In non-interactive mode, always return success (true).
+      if (this.nonInteractive) {
+        return true;
+      }
+


Q. It should return msg.defaultResponse instead of true?

Yes, we need to return true for isConfirmationPrompt, msg.defaultResponse if there is one, and continue otherwise.

I would also like us to still print the question and answer and indicating that --yes was used.

We should also only do this after the this.skipApprovalStep(msg) check. On the other hand, --yes should make scenarios work where we don't have a TTY or are using concurrency. So we will need to restructure the checks.

…nto feat/732-yes-flag

mrgrain

Two existing uses of promptly that should be changed over as well as part of this:

aws-cdk-cli/packages/aws-cdk/lib/cli/cdk-toolkit.ts

Line 980 in 5bb90cb

const confirmed = await promptly.confirm(

aws-cdk-cli/packages/aws-cdk/lib/cli/cdk-toolkit.ts

Line 2121 in 5bb90cb

const confirmed = await promptly.confirm(`${chalk.cyan(question)} (y/n)?`);

Refactor should be a confirm:

aws-cdk-cli/packages/@aws-cdk/toolkit-lib/lib/toolkit/toolkit.ts

Lines 1193 to 1196 in 5bb90cb

    
           const response = await ioHelper.requestResponse(IO.CDK_TOOLKIT_I8910.req(question, { 
        
             responseDescription: '[Y]es/[n]o', 
        
           }, 'y')); 
        
           return ['y', 'yes'].includes(response.toLowerCase());

mrgrain · 2025-09-30T09:46:05Z

packages/aws-cdk/lib/cli/io-host/cli-io-host.ts

+      // In non-interactive mode, always return success (true).
+      if (this.nonInteractive) {
+        return true;
+      }
+


Yes, we need to return true for isConfirmationPrompt, msg.defaultResponse if there is one, and continue otherwise.

I would also like us to still print the question and answer and indicating that --yes was used.

We should also only do this after the this.skipApprovalStep(msg) check. On the other hand, --yes should make scenarios work where we don't have a TTY or are using concurrency. So we will need to restructure the checks.

…rmationRequest interface (#904) This PR standardizes user confirmation flows across the CDK CLI by migrating from ad-hoc `promptly.confirm` usage to the structured `ConfirmationRequest` interface. These are the changes as suggested here: #826 (review) ## Changes - **Convert CDK_TOOLKIT_I8910**: Changed from `DataRequest` to `ConfirmationRequest` for refactor confirmation - **Standardize destroy flow**: Replace `promptly.confirm` with `IO.CDK_TOOLKIT_I7010` message - **Standardize deploy flow**: Update `askUserConfirmation` to use `ActionLessRequest<ConfirmationRequest>` pattern - **Clean up test infrastructure**: Remove deprecated `markTesting` function and `TESTING` variable - **Update tests**: Replace `promptly` mocks with `requestSpy` for consistency ## Benefits - Consistent user interaction patterns across all CLI commands - Better testability through standardized mocking - Improved error handling and TTY detection through the IO system - Cleaner separation of concerns between UI logic and business logic --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

mrgrain · 2025-10-07T12:40:30Z

Two existing uses of promptly that should be changed over as well as part of this:

aws-cdk-cli/packages/aws-cdk/lib/cli/cdk-toolkit.ts

Line 980 in 5bb90cb

const confirmed = await promptly.confirm(

aws-cdk-cli/packages/aws-cdk/lib/cli/cdk-toolkit.ts

Line 2121 in 5bb90cb

const confirmed = await promptly.confirm(`${chalk.cyan(question)} (y/n)?`);

Refactor should be a confirm:

aws-cdk-cli/packages/@aws-cdk/toolkit-lib/lib/toolkit/toolkit.ts

Lines 1193 to 1196 in 5bb90cb

const response = await ioHelper.requestResponse(IO.CDK_TOOLKIT_I8910.req(question, {

responseDescription: '[Y]es/[n]o',

}, 'y'));

return ['y', 'yes'].includes(response.toLowerCase());

I went ahead and made these unrelated changes in: #904

feat(cli): add non-interactive mode support to CLI

23b6ea9

ren-yamanashi had a problem deploying to integ-approval August 29, 2025 13:30 — with GitHub Actions Failure

github-actions bot added the p2 label Aug 29, 2025

aws-cdk-automation requested a review from a team August 29, 2025 13:31

ren-yamanashi changed the title ~~feat(cli): add non-interactive mode support to CLI~~ feat(cli): add --yes flag Aug 29, 2025

github-actions bot added feature-request p1 and removed p2 labels Aug 29, 2025

ren-yamanashi added 2 commits August 29, 2025 22:33

chore: fmt

70473b9

feat(cli): add 'yes' option to skip interactive prompts

71aec07

ren-yamanashi had a problem deploying to integ-approval August 29, 2025 13:44 — with GitHub Actions Failure

feat(cli): add 'yes' option to skip interactive prompts

ada6fb1

ren-yamanashi had a problem deploying to integ-approval August 29, 2025 13:50 — with GitHub Actions Failure

ren-yamanashi added 2 commits August 30, 2025 10:58

feat(cli): enhance 'yes' option description to clarify non-interactiv…

f26ab9e

…e behavior

feat(cli): add tests for non-interactive mode responses in CliIoHost

6275dc1

ren-yamanashi had a problem deploying to integ-approval August 30, 2025 02:29 — with GitHub Actions Failure

feat(cli): add support for --yes option in command line arguments and…

1830059

… test non-interactive mode

ren-yamanashi had a problem deploying to integ-approval August 30, 2025 02:56 — with GitHub Actions Failure

test: update

e7de2b9

ren-yamanashi had a problem deploying to integ-approval August 30, 2025 02:57 — with GitHub Actions Failure

feat(cli): update non-interactive mode to always return true for conf…

e6aac4a

…irmation prompts

ren-yamanashi had a problem deploying to integ-approval August 30, 2025 03:18 — with GitHub Actions Failure

ren-yamanashi commented Aug 30, 2025

View reviewed changes

feat(cli): clarify non-interactive mode behavior in documentation

155f625

ren-yamanashi temporarily deployed to integ-approval August 30, 2025 03:33 — with GitHub Actions Inactive

ren-yamanashi marked this pull request as ready for review August 30, 2025 03:33

ren-yamanashi had a problem deploying to run-tests September 3, 2025 22:44 — with GitHub Actions Failure

ren-yamanashi temporarily deployed to run-tests September 3, 2025 22:44 — with GitHub Actions Inactive

Merge branch 'main' of https://github.com/ren-yamanashi/aws-cdk-cli i…

cf7a224

…nto feat/732-yes-flag

ren-yamanashi had a problem deploying to integ-approval September 4, 2025 00:25 — with GitHub Actions Failure

mrgrain requested changes Sep 30, 2025

View reviewed changes

This was referenced Oct 2, 2025

feat(cli): gc can ignore user-verified unauthorized non-cdk stacks #850

Open

refactor(toolkit-lib): standardize confirmation requests to use ConfirmationRequest interface #904

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(cli): add --yes flag #826

feat(cli): add --yes flag #826

Uh oh!

ren-yamanashi commented Aug 29, 2025 •

edited

Loading

Uh oh!

codecov-commenter commented Aug 30, 2025 •

edited

Loading

Uh oh!

ren-yamanashi Aug 30, 2025 •

edited

Loading

Uh oh!

mrgrain Sep 30, 2025

Uh oh!

mrgrain left a comment

Uh oh!

mrgrain Sep 30, 2025

Uh oh!

mrgrain commented Oct 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	const response = await ioHelper.requestResponse(IO.CDK_TOOLKIT_I8910.req(question, {
	responseDescription: '[Y]es/[n]o',
	}, 'y'));
	return ['y', 'yes'].includes(response.toLowerCase());

Uh oh!

feat(cli): add --yes flag #826

Are you sure you want to change the base?

feat(cli): add --yes flag #826

Uh oh!

Conversation

ren-yamanashi commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ren-yamanashi Aug 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrgrain Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

mrgrain left a comment

Choose a reason for hiding this comment

Uh oh!

mrgrain Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

mrgrain commented Oct 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ren-yamanashi commented Aug 29, 2025 •

edited

Loading

codecov-commenter commented Aug 30, 2025 •

edited

Loading

ren-yamanashi Aug 30, 2025 •

edited

Loading