-
Couldn't load subscription status.
- Fork 51
feat(cli): change set review on deploy #892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| const execute = deploymentMethod.execute ?? true; | ||
| const importExistingResources = deploymentMethod.importExistingResources ?? false; | ||
| const changeSetDescription = await this.createChangeSet(changeSetName, execute, importExistingResources); | ||
| const executeExistingChangeSet = deploymentMethod.executeExistingChangeSet ?? false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support deploying/executing an existing CloudFormation change set.
97b1243 to
25acc82
Compare
25acc82 to
09163dd
Compare
09163dd to
b2bae60
Compare
b2bae60 to
ef4cdd3
Compare
ef4cdd3 to
7920c88
Compare
7920c88 to
5844733
Compare
5844733 to
91a2f71
Compare
91a2f71 to
c1e9805
Compare
c1e9805 to
797befd
Compare
797befd to
a4bedea
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #892 +/- ##
==========================================
+ Coverage 83.69% 84.14% +0.45%
==========================================
Files 65 65
Lines 9558 9634 +76
Branches 1135 1161 +26
==========================================
+ Hits 8000 8107 +107
+ Misses 1535 1501 -34
- Partials 23 26 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a4bedea to
bdc029f
Compare
bdc029f to
fbfa223
Compare
fbfa223 to
8e8d4c1
Compare
8e8d4c1 to
5ca2053
Compare
5ca2053 to
562c273
Compare
Implementation of #801 and RFC 370: CLI deploy with change set review confirmation.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license