Skip to content

Conversation

@orien
Copy link

@orien orien commented Sep 24, 2025

Implementation of #801 and RFC 370: CLI deploy with change set review confirmation.

This feature enhances the existing --require-approval=any-change option to show all stack changes (not just security changes) and integrates CloudFormation change set creation and review to provide users with an accurate preview of what will be applied before deployment execution.

Modern cloud infrastructure contains critical stateful resources—databases, persistent storage, message queues, and other systems that hold valuable data and maintain complex state. Engineers deploying changes to these environments carry significant responsibility: a single misunderstood deployment can lead to data loss, service outages, or security vulnerabilities that affect customers and business operations. While Infrastructure as Code provides repeatability and version control, it doesn't eliminate the fundamental need for engineers to understand precisely what changes will be applied before execution. Tooling must bridge this gap by providing clear, accurate previews of deployment impact—especially for stateful resources where "undo" isn't always possible. This enhancement ensures that engineers have the complete information they need to make informed decisions about infrastructure changes.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

const execute = deploymentMethod.execute ?? true;
const importExistingResources = deploymentMethod.importExistingResources ?? false;
const changeSetDescription = await this.createChangeSet(changeSetName, execute, importExistingResources);
const executeExistingChangeSet = deploymentMethod.executeExistingChangeSet ?? false;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support deploying/executing an existing CloudFormation change set.

@orien orien changed the title wip: working toward change set review on deploy feat(cli): change set review on deploy [WIP] Sep 24, 2025
@orien orien force-pushed the 0370-change-set-approval branch from 97b1243 to 25acc82 Compare September 25, 2025 06:11
@orien orien force-pushed the 0370-change-set-approval branch from 25acc82 to 09163dd Compare September 25, 2025 06:16
@orien orien force-pushed the 0370-change-set-approval branch from 09163dd to b2bae60 Compare September 25, 2025 12:54
@orien orien force-pushed the 0370-change-set-approval branch from b2bae60 to ef4cdd3 Compare September 25, 2025 15:02
@orien orien changed the title feat(cli): change set review on deploy [WIP] feat(cli): change set review on deploy Sep 25, 2025
@orien orien marked this pull request as ready for review September 25, 2025 15:04
@orien orien force-pushed the 0370-change-set-approval branch from ef4cdd3 to 7920c88 Compare September 25, 2025 17:43
@orien orien force-pushed the 0370-change-set-approval branch from 7920c88 to 5844733 Compare September 30, 2025 08:06
@orien orien force-pushed the 0370-change-set-approval branch from 5844733 to 91a2f71 Compare September 30, 2025 08:49
@orien orien force-pushed the 0370-change-set-approval branch from 91a2f71 to c1e9805 Compare September 30, 2025 09:40
@orien orien force-pushed the 0370-change-set-approval branch from c1e9805 to 797befd Compare October 1, 2025 03:33
@orien orien force-pushed the 0370-change-set-approval branch from 797befd to a4bedea Compare October 2, 2025 01:55
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 86.00000% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.14%. Comparing base (09c0061) to head (a4bedea).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
packages/aws-cdk/lib/cli/cdk-toolkit.ts 86.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #892      +/-   ##
==========================================
+ Coverage   83.69%   84.14%   +0.45%     
==========================================
  Files          65       65              
  Lines        9558     9634      +76     
  Branches     1135     1161      +26     
==========================================
+ Hits         8000     8107     +107     
+ Misses       1535     1501      -34     
- Partials       23       26       +3     
Flag Coverage Δ
suite.unit 84.14% <86.00%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@orien orien force-pushed the 0370-change-set-approval branch from a4bedea to bdc029f Compare October 7, 2025 08:27
@orien orien force-pushed the 0370-change-set-approval branch from bdc029f to fbfa223 Compare October 7, 2025 09:05
@orien orien force-pushed the 0370-change-set-approval branch from fbfa223 to 8e8d4c1 Compare October 8, 2025 01:34
@orien orien force-pushed the 0370-change-set-approval branch from 8e8d4c1 to 5ca2053 Compare October 12, 2025 05:43
@orien orien force-pushed the 0370-change-set-approval branch from 5ca2053 to 562c273 Compare October 26, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants