Skip to content

Conversation

@9pace
Copy link

@9pace 9pace commented Oct 28, 2025

Publish diagrams that illustrate the CDK deployment process at two levels of detail. The first diagram provides a conceptual overview suitable for understanding the high-level flow, while the second diagram shows the technical implementation details for contributors working on the CDK codebase.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@9pace 9pace requested a review from mrgrain October 28, 2025 16:31
@aws-cdk-automation aws-cdk-automation requested a review from a team October 28, 2025 16:32
@github-actions github-actions bot added the p2 label Oct 28, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.04%. Comparing base (75b8256) to head (73e4fd3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #920      +/-   ##
==========================================
+ Coverage   83.23%   84.04%   +0.81%     
==========================================
  Files          71       71              
  Lines       10396    10401       +5     
  Branches     1306     1318      +12     
==========================================
+ Hits         8653     8742      +89     
+ Misses       1705     1621      -84     
  Partials       38       38              
Flag Coverage Δ
suite.unit 84.04% <ø> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@9pace Love this 😍

Only thing is that this is a user facing README and I don't think this level of detail is needed or useful for them. In particular the part where the chart documents internal function calls.

Can you find a different place for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants