feat(cli): allow to parallelize asset build #983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #983 +/- ##
==========================================
+ Coverage 87.38% 87.41% +0.03%
==========================================
Files 71 71
Lines 10010 10022 +12
Branches 1311 1311
==========================================
+ Hits 8747 8761 +14
+ Misses 1240 1239 -1
+ Partials 23 22 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
force-pushed
the
asset-build-conc
branch
from
34cb8f4 to
297a3f8
Compare
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
force-pushed
the
asset-build-conc
branch
from
297a3f8 to
b110e59
Compare
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
force-pushed
the
asset-build-conc
branch
from
5280d78 to
a1ff2bf
Compare
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
force-pushed
the
asset-build-conc
branch
from
d89540f to
0c1ccf0
Compare
go-to-k
requested a deployment
to
integ-approval
GitHub Actions
Waiting
go-to-k
commented
Dec 8, 2025
| rollback: argv.rollback, | ||
| notices: argv.notices, | ||
| assetParallelism: argv['asset-parallelism'], | ||
| assetBuildConcurrency: argv['asset-build-concurrency'], |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| assetBuildConcurrency: argv['asset-build-concurrency'], |
Maybe we don't need this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #226
This PR adds the
--asset-build-concurrencyoption tocdk deployto parallelize asset build.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license