Simplify complex value hint in enhanced error format #10023
+15,258
−7,153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix addresses failures encountered on some systems when running the startlivetail unit tests through the AWS CLI test runner script at `scripts/ci/run-tests`. According to prompt toolkit documentation: > During the creation of a prompt_toolkit Application, we can specify > what input and output device to be used. By default, these are output > objects that correspond with sys.stdin and sys.stdout. In unit tests > however, we want to replace these. > - For the input, we want a “pipe input”. This is an input device, > in which we can programmatically send some input. It can be created > with create_pipe_input(), and that return either a PosixPipeInput or a > Win32PipeInput depending on the platform. Reference: https://python-prompt-toolkit.readthedocs.io/en/stable/pages/advanced_topics/unit_testing.html This change adds an optional `app_input`` parameter so that the test can be run with `create_pipe_input()` to replace the input for unit testing.
[v2] Fix start-live-tail tests
…zonaws.com) as endpoint-url (aws#9850) docs: add caution note for S3 endpoint-url parameter Add note to S3 configuration documentation warning users about potential unintended behavior when using --endpoint-url parameter, including S3 redirect issues. This was prompted by setting the global S3 endpoint (s3.amazonaws.com) as a custom endpoint URL caused PermanentRedirect errors, redirect loops, and configuration confusion. While the guidance is generalized to cover broader endpoint configuration concerns, it specifically advises against using the global S3 endpoint as an endpoint-url parameter value. Addresses aws#9479
…into feature/str-std-error
Remove duplicate article 'an' from documentation that incorrectly stated 'To get an a VPC attachment'. Co-authored-by: veradri <veradri@amazon.com>
…rs in documentation (aws#9982) * Update ParamShorthand DocGen to fix the case of a structure within a map. * Update test for testing deeply nested shorthand.
ashovlin
reviewed
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Simplifies the hint message shown when enhanced error format encounters complex nested structures. Also rebased on v2.
Before:
FieldName: <complex value> (Use --cli-error-format with json or yaml to see full details)After:
FieldName: <complex value>, --cli-error-format json recommended for full detailsThe new message frames json as a recommendation rather than implying it's the only way to see the data. Enhanced mode prioritizes readability for interactive use and still shows more than what users get today.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.