Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated failing Unit Tests to old PR: Add --prefer-private-ip argument to the eb ssh command #89 #307

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

yohanthshetty
Copy link
Contributor

@yohanthshetty yohanthshetty commented Feb 10, 2023

Issue #, if available:
This PR Fixes Issue 3

Description of changes:
Add --prefer-private-ip argument to the eb ssh command #89
In this PR I have updated the failing unit tests of an older PR titled "Add --prefer-private-ip argument to the eb ssh command #89" by user github user @blampe.
Thank You @blampe for your contribution.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yohanthshetty yohanthshetty merged commit 64346bb into master Feb 10, 2023
@brandonburkett
Copy link

This is great! Any ETA on a new release?

@yohanthshetty
Copy link
Contributor Author

yohanthshetty commented Feb 10, 2023

Hi @brandonburkett, I will update here with any estimates for next release.
The change was rolled back as it does not work as expected. Will update the PR with further details about the private-ip change here.

@brandonburkett
Copy link

brandonburkett commented Feb 13, 2023

Got it! Thanks for the update.

@yohanthshetty yohanthshetty deleted the test-branch branch March 15, 2023 05:59
@brandonburkett
Copy link

We are launching new enviroments, switching to t4g and with ipv4 cost update incoming, it would be great to be able to ssh in with private ip via eb ssh.

Is this feature still being worked on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support SSH to private IP
2 participants