Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated jobs client with enum Fix #616

Closed
wants to merge 5 commits into from
Closed

Conversation

sbSteveK
Copy link
Contributor

Fixed headers for jobs using enums to correctly build with shared libs on Windows.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@bretambrose bretambrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look right. Enums should not shift position. And there should be no other code changes than the conversion function declspec macro position

@sbSteveK sbSteveK closed this Aug 17, 2023
@sbSteveK sbSteveK deleted the jobs-generated-fix branch August 17, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants