Execute jobs when in samples #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfred2g
force-pushed
the
jobs_samples
branch
from
3806482
to
9ef5508
Compare
alfred2g
force-pushed
the
jobs_samples
branch
from
55a8d73
to
5e01ebb
Compare
sfod
requested changes
Nov 30, 2023
sfod
reviewed
Dec 4, 2023
sfod
requested changes
Dec 11, 2023
sfod
reviewed
Dec 11, 2023
sfod
approved these changes
Dec 12, 2023
sfod
reviewed
Dec 12, 2023
| @@ -539,7 +541,7 @@ namespace Utils | |||
| returnData.input_clientId = | |||
| cmdUtils.GetCommandOrDefault(m_cmd_client_id, Aws::Crt::String("test-") + Aws::Crt::UUID().ToString()); | |||
| returnData.input_thingName = cmdUtils.GetCommandRequired(m_cmd_thing_name); | |||
| returnData.input_jobId = cmdUtils.GetCommandRequired(m_cmd_job_id); | |||
| returnData.input_jobId = cmdUtils.GetCommandOrDefault(m_cmd_job_id, "1"); | |||
There was a problem hiding this comment.
Debatable: Set to empty string by default. And in the samples request for a job description only if jobId is set.
Co-authored-by: Igor Abdrakhimov <octosyllabic@gmail.com>
Co-authored-by: Igor Abdrakhimov <octosyllabic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execute jobs when not in CI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.