Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update codegen #710

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Update codegen #710

merged 1 commit into from
Apr 12, 2024

Conversation

sfod
Copy link
Contributor

@sfod sfod commented Apr 12, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sbSteveK
sbSteveK approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@sbSteveK sbSteveK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial: every get and set combo seems to have the exact same documentation without differentiating that one is setting and one is getting the value. It's pretty obvious what a get_thing vs. set_thing is doing but just weird to see identical definitions.

@sfod
Copy link
Contributor Author

sfod commented Apr 12, 2024

The doc messages for setters and getters come from the corresponding field descriptions. I tried to prepend these messages with Set and Get , but it made some of them to look worse. So I decided to add these docs as-is.

@sfod sfod merged commit 7781444 into main Apr 12, 2024
37 of 38 checks passed
@sfod sfod deleted the update-codegen branch April 12, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbSteveK sbSteveK sbSteveK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfod @sbSteveK @sfodagain