Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Greengrass samples in CI #717

Merged
merged 81 commits into from
Jun 5, 2024
Merged

Run Greengrass samples in CI #717

merged 81 commits into from
Jun 5, 2024

Conversation

sfod
Copy link
Contributor

@sfod sfod commented May 16, 2024 •
edited
Loading

  • Add tests for Greengrass samples: IPC and discovery.
  • Add new CI job for Greengrass tests.
  • Fix greengrass-discovery sample to iterate over all connections it discovered.
  • Add to run_in_ci.py script a possibility to provide data to runnable's stdin.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sfod sfod marked this pull request as ready for review May 29, 2024 21:07
xiazhvera
xiazhvera reviewed May 31, 2024
View reviewed changes
Copy link
Contributor

@xiazhvera xiazhvera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put some questions here. In general the PR looks good to me in. It is impressive to clean up the GG testing workflow here.

samples/greengrass/basic_discovery/main.cpp Outdated Show resolved Hide resolved
@sfod sfod merged commit bd27a4d into main Jun 5, 2024
40 checks passed
@sfod sfod deleted the add-gg-ci-job branch June 5, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiazhvera xiazhvera xiazhvera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfod @xiazhvera @sfodagain