Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race conditions in samples and service tests #748

Merged
merged 5 commits into from
Sep 11, 2024
Merged

Conversation

sfod
Copy link
Contributor

@sfod sfod commented Sep 10, 2024

Issue #, if available:

There are race conditions in Fleet provisioning service tests and Secure tunnel sample (caught by this PR #703).

Description of changes:

  • I recently fixed a race condition in Fleet provisioning sample, so I reused that code in Fleet provisioning service tests.
  • Secure tunnel sample used sleep to sync two threads, I added a promise.
  • Additional change: use std::unique_ptr instead of raw pointers in samples.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sfod sfod merged commit 6bf060a into main Sep 11, 2024
39 of 40 checks passed
@sfod sfod deleted the fix-race-conditions branch September 11, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants