feat: add workload test case for external tests #700
+158
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick J.P. Culp <jpculp@amazon.com>
ndbaker1
reviewed
Oct 17, 2025
Comment on lines
+36
to
+44
| if *workloadTestCommand == "" { | ||
| t.Fatal(fmt.Errorf("workloadTestCommand must be set to run workload test")) | ||
| } | ||
| if *workloadTestImage == "" { | ||
| t.Fatal(fmt.Errorf("workloadTestImage must be set to run workload test")) | ||
| } | ||
| if *workloadTestName == "" { | ||
| t.Fatal(fmt.Errorf("workloadTestName must be set to run workload test")) | ||
| } |
There was a problem hiding this comment.
nit: just shortening
Suggested change
| if *workloadTestCommand == "" { | |
| t.Fatal(fmt.Errorf("workloadTestCommand must be set to run workload test")) | |
| } | |
| if *workloadTestImage == "" { | |
| t.Fatal(fmt.Errorf("workloadTestImage must be set to run workload test")) | |
| } | |
| if *workloadTestName == "" { | |
| t.Fatal(fmt.Errorf("workloadTestName must be set to run workload test")) | |
| } | |
| if *workloadTestCommand == "" { | |
| t.Fatal("workloadTestCommand must be set to run workload test") | |
| } | |
| if *workloadTestImage == "" { | |
| t.Fatal("workloadTestImage must be set to run workload test") | |
| } | |
| if *workloadTestName == "" { | |
| t.Fatal("workloadTestName must be set to run workload test") | |
| } |
| }). | ||
| Assess("Single node test Job succeeds", func(ctx context.Context, t *testing.T, cfg *envconf.Config) context.Context { | ||
| job := &batchv1.Job{ | ||
| ObjectMeta: metav1.ObjectMeta{Name: *workloadTestName, Namespace: "default"}, |
There was a problem hiding this comment.
nit: is there a default namespace enum in corev1 we can use just for posterity?
| if err != nil { | ||
| t.Error(err) | ||
| } else { | ||
| t.Log(fmt.Sprintf("Test log for %s:", *workloadTestName)) |
There was a problem hiding this comment.
Suggested change
| t.Log(fmt.Sprintf("Test log for %s:", *workloadTestName)) | |
| t.Logf("Test log for %s:", *workloadTestName) |
There was a problem hiding this comment.
this template is actually so minimal i feel like its worth just using the go type for?
There was a problem hiding this comment.
just want to nit the naming, "workload" is pretty broad, could we pick a clear name with a theme like "jobTemplate"? I'm really open to suggestions but i want to make sure this is sane/immediately readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adds a simple workload test case that runs a command or script within a test container.
Sample output from Python-based "Hello world" type of container:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.