Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options lambdaurl.WithDetectContentType and lambda.WithContextValue #516

Merged
merged 15 commits into from
Dec 1, 2023

Conversation

bmoffatt
Copy link
Collaborator

Issue #, if available:

#508

Description of changes:

Adds an option to utilize the stblib http.DetectContentType on the first Write to a lambda url response writer. This is done by adding a lambda.WithContextValue as a mechinisim to squirrel arbitrary context values in StartWithOptions wrappers like lambdaurl.Start

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (1dca084) 72.90% compared to head (0ea7933) 72.93%.

Files Patch % Lines
lambda/handler.go 12.50% 6 Missing and 1 partial ⚠️
lambdaurl/http_handler.go 94.59% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
+ Coverage   72.90%   72.93%   +0.03%     
==========================================
  Files          26       26              
  Lines        1421     1456      +35     
==========================================
+ Hits         1036     1062      +26     
- Misses        314      322       +8     
- Partials       71       72       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmoffatt bmoffatt marked this pull request as ready for review November 30, 2023 21:28
@bmoffatt bmoffatt added enhancement type/lambdaurl Issue or feature request related to the lambdaurl package labels Nov 30, 2023
@bmoffatt bmoffatt merged commit 752114b into aws:main Dec 1, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement type/lambdaurl Issue or feature request related to the lambdaurl package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants