Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Manager trait for Docker #508

Open
wants to merge 1 commit into
base: dockerless_feature
Choose a base branch
from

Commits on May 26, 2023

  1. Implement ImageManager trait for docker use

    - Changed docker.rs to contain the implementation of ImageManager trait.
      The DockerImageManager struct uses the old logic with shiplift.
    - Changed lib.rs to use a runtime-set image manager, which can be oci or
      docker, depending if the new --oci-uri flag is used or not.
    - Refactored the 'inspect_image' method to return OCI-compliant image
      metadata in case OciImageManager is used, instead of a Docker-specific one.
    - Changed enclave_build/src/main.rs to include the new additions.
    - Matched the OCI behavior by pulling or building the Docker image on
      manager creation based on the present arguments.
    
    Signed-off-by: Calin-Alexandru Coman <calincom@amazon.com>
    Signed-off-by: Raul-Ovidiu Moldovan <raulmldv@amazon.com>
    Calin-Alexandru Coman authored and raulmldv committed May 26, 2023
    Configuration menu
    Copy the full SHA
    eef11ba View commit details
    Browse the repository at this point in the history