Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1112

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Update README.md #1112

merged 1 commit into from
Dec 18, 2024

Conversation

Lu-David
Copy link
Contributor

Issue #, if available:

Description of changes:
Lifecycle hooks are NOT supported in IMDS. README is misleading. Need to update. However, termination based on target lifecycle state is supported in IMDS mode.

How you tested your changes:
Environment (Linux / Windows):
Kubernetes Version:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Lu-David Lu-David requested a review from a team as a code owner December 17, 2024 23:42
Copy link
Contributor

@tiationg-kho tiationg-kho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Lu-David Lu-David merged commit c27fa9a into main Dec 18, 2024
11 checks passed
@Lu-David Lu-David deleted the Lu-David-patch-1 branch December 18, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants