Skip to content

Commit

Permalink
fix(platform-aws): fill all platform values
Browse files Browse the repository at this point in the history
commit ce214aa rearranged fields such that the written initializers were
valid on most modern compilers, but it went unnoticed that this is
insufficient for AL2's ancient toolchain, which fails with:

> sorry, unimplemented: non-trivial designated initializers not supported

provide all members for all entries to fix this.

stack-info: PR: #595, branch: aws-nslick/stack/36
  • Loading branch information
aws-nslick committed Sep 14, 2024
1 parent 6b9309a commit 54cff5b
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion src/platform-aws.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ struct ec2_platform_data {
bool net_flush_required;
const char *default_protocol;
int domain_per_thread;
} platform_data_map[] = {
};

static struct ec2_platform_data platform_data_map[] = {
{
.name = "p4d.24xlarge",
.topology = "p4d-24xl-topo.xml",
Expand Down Expand Up @@ -88,20 +90,28 @@ struct ec2_platform_data {
{
.name = "g5.48xlarge",
.topology = "g5.48xl-topo.xml",
.default_dup_conns = 0,
.latency = 75.0,
.gdr_required = false,
.net_flush_required = true,
.default_protocol = "SENDRECV",
.domain_per_thread = 0,
},
{
.name = "trn1.32xlarge",
.topology = NULL,
.default_dup_conns = 0,
.latency = 75.0,
.gdr_required = true,
.net_flush_required = true,
.default_protocol = "RDMA",
.domain_per_thread = 1,
},
{
.name = "trn1n.32xlarge",
.topology = NULL,
.default_dup_conns = 0,
.latency = 75.0,
.gdr_required = true,
.net_flush_required = true,
.default_protocol = "RDMA",
Expand Down

0 comments on commit 54cff5b

Please sign in to comment.