Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add [[maybe_unused]] on EXPORT macro #559

Closed
wants to merge 6 commits into from
Closed

build: add [[maybe_unused]] on EXPORT macro #559

wants to merge 6 commits into from

Commits on Sep 4, 2024

  1. tree: fix __cplusplus guards 

    the canonical token is __cplusplus not _cplusplus. When this is
incorrect, linkage fails as cxx will perform name mangling when
including these headers, resulting in a function with that mangle not
existing.

stack-info: PR: #554, branch: aws-nslick/stack/1
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
    @aws-nslick
    aws-nslick committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    5a70a2f View commit details
    Browse the repository at this point in the history

  2. tree: add spaces around PRIu64 

    c++ requires literals not sit directly next to other literals and must
be separated by at least one whitespace token.

stack-info: PR: #555, branch: aws-nslick/stack/2
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
    @aws-nslick
    aws-nslick committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    f2e1b4f View commit details
    Browse the repository at this point in the history

  3. tree: add static_assert shim macro 

    stack-info: PR: #556, branch: aws-nslick/stack/3
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
    @aws-nslick
    aws-nslick committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    af6fa53 View commit details
    Browse the repository at this point in the history

  4. platform-aws: align declaration and init order 

    When using designated initializer lists, under C++ only, a warning will
be emitted if the declaration order does not match the initialization
order if any fields are missing in the initializer list. Reorder these
structs to initialize all fields in their declaration order.

stack-info: PR: #557, branch: aws-nslick/stack/4
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
    @aws-nslick
    aws-nslick committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    0fae450 View commit details
    Browse the repository at this point in the history

  5. rdma: fi_{send,write}data: do arithmetic on uintptr 

    void pointer arithmetic is illegal in c++; cast to uintptr, do the
offset, then cast to void* to pass to libfabric.

stack-info: PR: #558, branch: aws-nslick/stack/5
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
    @aws-nslick
    aws-nslick committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    af00dd1 View commit details
    Browse the repository at this point in the history

  6. build: add [[maybe_unused]] on EXPORT macro 

    stack-info: PR: #559, branch: aws-nslick/stack/6
Signed-off-by: Nicholas Sielicki <nslick@amazon.com>
    @aws-nslick
    aws-nslick committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    0d00bc2 View commit details
    Browse the repository at this point in the history