Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(param): move some parameters to unsigned #571

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/nccl_ofi_param.h
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ OFI_NCCL_PARAM_INT(cuda_flush_enable, "CUDA_FLUSH_ENABLE", 0);
* Specify the memory registration key size in bytes when using a libfabric
* provider that supports application-selected memory registration keys.
*/
OFI_NCCL_PARAM_INT(mr_key_size, "MR_KEY_SIZE", 2);
OFI_NCCL_PARAM_UINT(mr_key_size, "MR_KEY_SIZE", 2);

/*
* Disable the MR cache. The MR cache is used to keep track of registered
Expand Down Expand Up @@ -244,7 +244,7 @@ OFI_NCCL_PARAM_INT(net_latency, "NET_LATENCY", -1);
* tweak defaults from the platform file, but this fits our needs for
* now.
*/
OFI_NCCL_PARAM_INT(eager_max_size, "EAGER_MAX_SIZE",
OFI_NCCL_PARAM_UINT(eager_max_size, "EAGER_MAX_SIZE",
#if HAVE_NEURON
0
#else
Expand Down
Loading