Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): check features before mangling CFLAGS #589

Open
wants to merge 1 commit into
base: aws-nslick/stack/29
Choose a base branch
from
Open

fix(build): check features before mangling CFLAGS #589

wants to merge 1 commit into from

Commits on Sep 17, 2024

  1. fix(build): check features before mangling CFLAGS 

    Yet another autotools fix: If any warning/devel CFLAGS would invoke
warnings in headers used to detect dependencies, those dependencies will
fail with a highly misleading/confusing error message:

> configure: Found .git directory.  Adding -Werror to CFLAGS.
> checking if running on EC2 instance... yes
> checking if want AWS platform optimizations... yes
> checking for Libfabric 1.18.0 or later... no
> configure: error: On AWS platforms, Libfabric 1.18.0 or later is required

ie: it is not that Libfabric 1.18 was not found, it was that its headers
produced warnings. Fix this by resolving all dependencies before
modifying CFLAGS.

stack-info: PR: #589, branch: aws-nslick/stack/31
    @aws-nslick
    aws-nslick committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    201ec50 View commit details
    Browse the repository at this point in the history