Install enroot + pyxis in AMIs during build process #2793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himani2411
reviewed
Aug 22, 2024
cookbooks/aws-parallelcluster-slurm/recipes/install/install_pyxis.rb
Outdated
Show resolved
Hide resolved
himani2411
reviewed
Aug 22, 2024
cookbooks/aws-parallelcluster-slurm/recipes/install/install_pyxis.rb
Outdated
Show resolved
Hide resolved
himani2411
reviewed
Aug 22, 2024
| user 'root' | ||
| code <<-PYXIS_INSTALL | ||
| set -e | ||
| git clone --depth 1 --branch #{pyxis_version} https://github.com/NVIDIA/pyxis.git /tmp/pyxis |
There was a problem hiding this comment.
If I am not wrong, the pyxis+enroot is useful for GPU instance type's
If so do we need to check if NVIDIA is already installed?
And is there a version compatibility matrix for NVIDIA + pyxis + enroot?
himani2411
reviewed
Aug 22, 2024
cookbooks/aws-parallelcluster-slurm/recipes/install/install_pyxis.rb
Outdated
Show resolved
Hide resolved
himani2411
reviewed
Aug 22, 2024
himani2411
reviewed
Aug 22, 2024
cookbooks/aws-parallelcluster-platform/resources/enroot/enroot_alinux2023.rb
Outdated
Show resolved
Hide resolved
himani2411
reviewed
Aug 22, 2024
cookbooks/aws-parallelcluster-platform/resources/enroot/partial/_enroot_rhel.rb
Outdated
Show resolved
Hide resolved
himani2411
reviewed
Aug 22, 2024
| # Enroot + Pyxis | ||
| default['cluster']['enroot']['version'] = '3.4.1' | ||
| default['cluster']['pyxis']['version'] = 'v0.19.0' | ||
|
|
There was a problem hiding this comment.
Please add Kitchen and Unit tests for these changes
hgreebe
force-pushed
the
enroot
branch
2 times, most recently
from
fe1fec9
to
e509afe
Compare
hgreebe
force-pushed
the
enroot
branch
7 times, most recently
from
97a10ea
to
4c2f599
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2793 +/- ##
===========================================
+ Coverage 76.47% 76.70% +0.23%
===========================================
Files 22 22
Lines 2219 2237 +18
===========================================
+ Hits 1697 1716 +19
+ Misses 522 521 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hgreebe
force-pushed
the
enroot
branch
5 times, most recently
from
397b49e
to
2cdcf4d
Compare
himani2411
previously approved these changes
Aug 26, 2024
himani2411
approved these changes
Aug 27, 2024
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.