Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependencies] Rename Enroot+Caps object URL from enroot+caps to enroot-caps to prevent URL encoding issues on RHEL and Debian. #2810

Merged

Conversation

gmarciani
Copy link
Contributor

@gmarciani gmarciani commented Sep 17, 2024

Description of changes

Rename Enroot+Caps object URL from enroot+caps (encoded is enroot%2Bcaps) to enroot-caps to prevent URL encoding issues on RHEL and Debian.

In fact we observed the following URL encoding issue:

  • on RHEL9 enroot%2Bcaps is interpreted as it should be, i.e. enrott+caps
  • on RHEL8 enroot%2Bcaps is translated into enroot%252Bcaps.

To prevent this behaviour we decided to resolve by avoid the use of special characters in the object URL.

Tests

  • Describe the automated and/or manual tests executed to validate the patch.
  • Describe the added/modified tests.

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…ot-caps to prevent URL encoding issues on RHEL and Debian.

Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>
@gmarciani gmarciani marked this pull request as ready for review September 17, 2024 16:42
@gmarciani gmarciani requested review from a team as code owners September 17, 2024 16:42
@gmarciani gmarciani enabled auto-merge (rebase) September 17, 2024 17:32
auto-merge was automatically disabled September 17, 2024 19:26

Pull request was closed

@hgreebe hgreebe merged commit 1967c7b into aws:develop Sep 17, 2024
71 of 80 checks passed
@gmarciani gmarciani deleted the wip/mgiacomo/311/enroot-caps-url-0917-1 branch September 17, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants