Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple OSU benchmarks from EFA integration tests #5928

Merged
merged 5 commits into from
Dec 20, 2023

Conversation

judysng
Copy link
Contributor

@judysng judysng commented Dec 11, 2023

Description of changes

  • Originally, OSU benchmark tests were nested inside EFA integration tests, so this PR makes a new test_osu.py and separated the OSU tests from EFA
    • This is placed in the performance_tests folder, along with a new cluster config specifically using c5n.18xlarge and the benchmarks
  • OSU benchmarks could also be run from other tests (test_ad_integration, test_multiple_efs, test_multiple_fsx, and test_hit_disable_hyperthreading) if the test config option "benchmarks" was set.
    • This PR also removes the benchmark config sections from those tests and deletes the extra code in those tests that uses the fixture and runs the test
    • The actual fixture and test config option is left though, just in case for future use

Tests

  • Ran integration tests for each of the tests modified (osu, efa, efs, ad_integration, fsx, and disable_hyperthreading)

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@judysng judysng requested review from a team as code owners December 11, 2023 04:48
@judysng judysng added the skip-changelog-update Disables the check that enforces changelog updates in PRs label Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dffb3a0) 90.15% compared to head (823f895) 90.15%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5928   +/-   ##
========================================
  Coverage    90.15%   90.15%           
========================================
  Files          180      180           
  Lines        15742    15742           
========================================
  Hits         14192    14192           
  Misses        1550     1550           
Flag Coverage Δ
unittests 90.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@judysng judysng force-pushed the decouple branch 3 times, most recently from 5196287 to 1d8e402 Compare December 18, 2023 20:36
Signed-off-by: Judy Ng <njud@amazon.com>
Signed-off-by: Judy Ng <njud@amazon.com>
Signed-off-by: Judy Ng <njud@amazon.com>
Signed-off-by: Judy Ng <njud@amazon.com>
Signed-off-by: Judy Ng <njud@amazon.com>
@judysng judysng merged commit 742ba68 into aws:develop Dec 20, 2023
25 checks passed
enrico-usai pushed a commit to enrico-usai/aws-parallelcluster that referenced this pull request Jan 30, 2024
* Decouple OSU test from EFA tests

Signed-off-by: Judy Ng <njud@amazon.com>
Signed-off-by: Enrico Usai <usai@amazon.com>
enrico-usai pushed a commit that referenced this pull request Jan 30, 2024
* Decouple OSU test from EFA tests

Signed-off-by: Judy Ng <njud@amazon.com>
Signed-off-by: Enrico Usai <usai@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants