Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CRT to v0.18.13 for C++ ODR Violations #2137 #2187

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Conversation

SergeyRyabinin
Copy link
Contributor

@SergeyRyabinin SergeyRyabinin commented Nov 9, 2022

Issue #, if available:
#2137
Description of changes:
Fixed in CRT C dependencies, updating the sub-module.
Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@SergeyRyabinin
Copy link
Contributor Author

CI is passing.
Will merge after the release.

@SergeyRyabinin
Copy link
Contributor Author

CI has passed, to be merged after the release.

@SergeyRyabinin SergeyRyabinin merged commit 48f98f7 into main Nov 9, 2022
@SergeyRyabinin SergeyRyabinin deleted the crt/v0.18.13 branch November 9, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants