-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added lost usage of USE_AWS_MEMORY_MANAGEMENT #2424
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyRyabinin
approved these changes
Mar 31, 2023
If you do not add CUSTOM_MEMORY_MANAGEMENT test support to RunTests, not sure this will get tested. When I made similar changes earlier today, the unit tests in aws-sdk-cpp bombed out. Here's an interesting RunTests.cpp... but any CI needs to have a test run with
|
sbiscigl
force-pushed
the
fix_custom_mem_management
branch
from
July 10, 2023 20:21
f018489
to
722f6f7
Compare
sbiscigl
force-pushed
the
fix_custom_mem_management
branch
from
October 19, 2023 19:56
722f6f7
to
f5f5e87
Compare
SergeyRyabinin
force-pushed
the
fix_custom_mem_management
branch
from
December 19, 2023 00:27
f5f5e87
to
3f5e4d5
Compare
sbiscigl
approved these changes
Dec 19, 2023
SergeyRyabinin
force-pushed
the
fix_custom_mem_management
branch
from
December 20, 2023 18:33
3f5e4d5
to
690b22a
Compare
SergeyRyabinin
force-pushed
the
fix_custom_mem_management
branch
from
January 3, 2024 22:58
690b22a
to
042c5f7
Compare
SergeyRyabinin
force-pushed
the
fix_custom_mem_management
branch
from
January 4, 2024 19:57
042c5f7
to
da08cdf
Compare
SergeyRyabinin
force-pushed
the
fix_custom_mem_management
branch
2 times, most recently
from
January 4, 2024 22:01
9d17fa2
to
733b5fd
Compare
SergeyRyabinin
force-pushed
the
fix_custom_mem_management
branch
from
January 4, 2024 23:30
733b5fd
to
a0d1197
Compare
sbiscigl
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.