Fix template class instantiation #2558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For Windows DLL, export definition of template class instantiation directly in the header using __declspec(dllexport). - For other builds (including Windows static lib), declare as extern in the header and define in the cpp. This change is required to fix 'multiple definition of typeinfo' linker errors seen with some compilers, e.g. GCC for 32-bit armhf arm-linux-gnueabihf-gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1).
SergeyRyabinin
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is required to fix 'multiple definition of typeinfo' linker errors seen with some compilers, e.g. GCC for 32-bit armhf arm-linux-gnueabihf-gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1).
Issue #, if available:
Description of changes:
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.