Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates init retry strategy log level #2562

Merged
merged 1 commit into from
Jul 3, 2023
Merged

Conversation

sbiscigl
Copy link
Contributor

@sbiscigl sbiscigl commented Jul 3, 2023

Description of changes:

The deafult ctor for ClientConfiguration will log a warning statement that default retry count is used, unless a env variable or config file variable is present to update the max retry count. This warning is noise, and should be a info statement. The deafult ctor should not emit warning logging statements for choosing deafults.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl marked this pull request as ready for review July 3, 2023 16:52
@sbiscigl sbiscigl merged commit 2ee3404 into main Jul 3, 2023
3 checks passed
@sbiscigl sbiscigl deleted the sb/client-config-log-level branch July 3, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants