Issue 2568 #2569
Merged
Issue 2568 #2569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change caused redundant calls to Aws::ShutdownAPI() to crash, with SEGV, due to null pointer dereference. This commit fixes this regression and adds a unit test that shows that calling Aws::ShutdownAPI() multiple times no longer crashes.
| @@ -42,7 +42,6 @@ namespace Aws | |||
| void ShutdownComponentRegistry() | |||
| { | |||
| std::unique_lock<std::mutex> lock(s_registryMutex); | |||
| assert(s_registry); | |||
There was a problem hiding this comment.
I would prefer to keep these asserts, but it will crash apps build in debug mode.
SergeyRyabinin
approved these changes
Jul 11, 2023
sbiscigl
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#2568
Description of changes:
A recent change caused redundant calls to Aws::ShutdownAPI() to crash, with
SEGV, due to null pointer dereference.
This commit fixes this regression and adds a unit test that shows that
calling Aws::ShutdownAPI() multiple times no longer crashes.
Also updates function CleanupEnumOverflowContainer() to prevent a
double-free on shutdown.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.