Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #2590 : Fixes conflicts with ERROR macro in wingdi.h #2591

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

yasminetalby
Copy link
Contributor

Issue #, if available: #2590

Description of changes:

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yasminetalby yasminetalby marked this pull request as draft July 24, 2023 19:31
@hthompson6
Copy link

Thank you for going this route instead of simply undefining things as has been done historically and was recommended by the bug poster!

@hthompson6
Copy link

This line also needs to be change for a successful build

@yasminetalby yasminetalby marked this pull request as ready for review August 2, 2023 16:24
@yasminetalby yasminetalby merged commit 314c1d7 into main Aug 17, 2023
3 checks passed
@jmklix jmklix deleted the fix2590 branch August 31, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants