Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing definition for GenerateSignature #2601

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

sbiscigl
Copy link
Contributor

Issue #, if available:

issues/2599

Description of changes:

There was a missing definition for the public function

Aws::String GenerateSignature(const Aws::Auth::AWSCredentials& credentials,
  const Aws::String& stringToSign, 
  const Aws::String& simpleDate) const;

In the sigv4 signer. This PR adds the implementation and calls the corresponding private method.

We also tidy up and remove another un-implemented private fucntion.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl marked this pull request as ready for review July 31, 2023 15:53
@sbiscigl sbiscigl merged commit d62e545 into main Jul 31, 2023
3 checks passed
@sbiscigl sbiscigl deleted the missing-signer-impl branch July 31, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants