Add cmake parameter to enforce tls version #2604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbiscigl
force-pushed
the
enforce-tls-version
branch
2 times, most recently
from
55e68fa
to
958868d
Compare
sbiscigl
force-pushed
the
enforce-tls-version
branch
from
958868d
to
dd4818a
Compare
SergeyRyabinin
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
these changes have no effect with current versions of curl 8 since LIBCURL_VERSION_MINOR would be <34.
For curl version range checks LIBCURL_VERSION_NUM might be a better choice
https://curl.se/docs/versions.html
also, CURL_SSLVERSION_TLSv1_3 is available as of curl 7.52 according to curl documentation
https://curl.se/libcurl/c/CURLOPT_SSLVERSION.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adds two cmake parameters
USE_TLS_V2andUSE_TLS_V3that force the http client to use TLS 1.2 or 1.3. Currently they default to 1.2 per AWS guidance.Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.