Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect usage of GetModuleFileNameW win api #2670

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Fix incorrect usage of GetModuleFileNameW win api #2670

merged 2 commits into from
Sep 15, 2023

Conversation

DmitriyMusatkin
Copy link
Contributor

Issue #, if available:

Description of changes:
#1773

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@DmitriyMusatkin DmitriyMusatkin merged commit 5c4c619 into main Sep 15, 2023
3 checks passed
@DmitriyMusatkin DmitriyMusatkin deleted the exe-path branch September 15, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyRyabinin SergeyRyabinin SergeyRyabinin approved these changes

@sbiscigl sbiscigl sbiscigl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DmitriyMusatkin @sbiscigl @SergeyRyabinin