Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using stdext::checked_array_iterator. #2726

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Stop using stdext::checked_array_iterator. #2726

merged 1 commit into from
Nov 17, 2023

Conversation

teo-tsirpanis
Copy link
Contributor

@teo-tsirpanis teo-tsirpanis commented Oct 20, 2023

Issue #, if available:
N/A

Description of changes:
stdext::checked_array_iterator will be deprecated in Visual Studio 17.8 (microsoft/STL#3818), does not exist in MinGW, and the uses of it in the SDK would never fail either way.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.) - The change is trivial and only removes code
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms (MinGW)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

It will be deprecated in Visual Studio 17.8, does not exist in MinGW, and the uses of it in the SDK would never fail.
teo-tsirpanis added a commit to teo-tsirpanis/TileDB that referenced this pull request Oct 23, 2023
@SergeyRyabinin SergeyRyabinin merged commit 089dc3a into aws:main Nov 17, 2023
2 of 3 checks passed
@teo-tsirpanis teo-tsirpanis deleted the stdext-remove branch November 17, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants