Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty requests for apis without input for rest-json services #2738

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

sbiscigl
Copy link
Contributor

@sbiscigl sbiscigl commented Nov 8, 2023

Description of changes:

Very similar to pull/2634. That fixed broken calls for APIs where empty requests were needed for json services to pass needed headers. We however did not include rest-json services in that PR because it appeared that they worked as intended. We discovered a service resource-explorer-2 however that does require an empty body to be sent alongside requests with no input. This change no does this and fixes the APIs DisassociateDefaultView, GetDefaultView, and GetIndex that did not work previously. We are now going to send empty bodies in all no input rest-json requests uniformly as there is no guidence on whether or not to do so. This effects a total of 22 apis.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl marked this pull request as ready for review November 9, 2023 16:28
@sbiscigl sbiscigl merged commit bf1532e into main Nov 9, 2023
4 checks passed
@sbiscigl sbiscigl deleted the rest-json-requestless branch November 9, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants