Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix curl headers when value is absent #2750

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Fix curl headers when value is absent #2750

merged 1 commit into from
Nov 14, 2023

Conversation

sbiscigl
Copy link
Contributor

Description of changes:

Right now if a S3 request is made like

PutObjectRequest().WithMetadata({{"KeyWithValue", "value"}, {"KeyWithoutValue", ""}});

this will result in a curl request with headers like

[DEBUG] 2023-11-14 15:37:57.397 CURL [0x1de241b40] (HeaderOut) PUT /test.txt HTTP/1.1
Host: sbiscigl.s3.us-east-1.amazonaws.com
...
x-amz-meta-keywithvalue: value
...

without the header without value. after this change it will look like

[DEBUG] 2023-11-14 15:42:21.551 CURL [0x1de241b40] (HeaderOut) PUT /test.txt HTTP/1.1
...
x-amz-meta-keywithoutvalue:
x-amz-meta-keywithvalue: value
...

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl marked this pull request as ready for review November 14, 2023 21:04
@sbiscigl sbiscigl merged commit 690fa43 into main Nov 14, 2023
4 checks passed
@sbiscigl sbiscigl deleted the empty-header-curl-fix branch November 14, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants