Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use curl in config mode if include and lib missing #2817

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

sbiscigl
Copy link
Contributor

@sbiscigl sbiscigl commented Jan 19, 2024

Issue #, if available:

issues/2717

Description of changes:

As mentioned in the issue

Right now it does not seem possible to use a custom build of Curl built with CMake when it is installed in Config mode.

which is true, as of the moment if you build curl from source the only way you can is by building it with autoconf. This changes to fall back to use curl by configuration if we cannot find the needed include or lib dirs from FindCURL.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@pr0g pr0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! 😄 Thanks for adding support for this 🥳

cmake/external_dependencies.cmake Outdated Show resolved Hide resolved
cmake/dependencies.cmake Outdated Show resolved Hide resolved
cmake/external_dependencies.cmake Outdated Show resolved Hide resolved
@sbiscigl sbiscigl force-pushed the config-mode-curl branch 2 times, most recently from e80bac7 to 265f238 Compare January 19, 2024 18:43
@sbiscigl sbiscigl marked this pull request as ready for review January 19, 2024 20:41
@sbiscigl sbiscigl merged commit 07232df into main Jan 19, 2024
3 of 4 checks passed
@sbiscigl sbiscigl deleted the config-mode-curl branch January 19, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants