Add constructor overload to STSProfileCredentialsProvider
where the client factory returns a shared pointer.
#2830
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The
STSProfileCredentialProvider
class has a constructor overload that accepts anSTSClient
factory function. The problem with this function is that it returns anSTSClient*
, making lifetime management tricky in certain cases.This PR introduces an additional overload that accepts an factory that returns a
shared_ptr<STSClient>
. This will enable the client to be freed automatically when the credentials provider no longer needs it.The existing constructor overload wraps the
STSClient*
into a shared pointer with a deleter that does nothing, maintaining compatibility. I also added an overload to disambiguate between creating a credential provider with anullptr
factory.Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.