Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor and fix curl metrics #2888

Merged
merged 1 commit into from
Mar 14, 2024
Merged

refactor and fix curl metrics #2888

merged 1 commit into from
Mar 14, 2024

Conversation

sbiscigl
Copy link
Contributor

Issue #, if available:

issues/2883

Description of changes:

There were some more inconsistencies in curl metrics not initially brought up in the ticket, this fixes them

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl marked this pull request as ready for review March 13, 2024 20:00
@jmklix jmklix linked an issue Mar 13, 2024 that may be closed by this pull request
@sbiscigl sbiscigl merged commit 623da54 into main Mar 14, 2024
3 of 4 checks passed
@sbiscigl sbiscigl deleted the refactor-curl-metrics branch March 14, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-cpp-sdk-core/source/http/curl/CurlHttpClient.cpp: Bad call to cURL
2 participants