Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add configuration to preserve path seperator in URIs #2891

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

sbiscigl
Copy link
Contributor

Description of changes:

Currently the C++ SDK sanitizes/normalizes uri paths that prevents us from interacting with other SDKs S3 keys. for example a S3 object with the key ///cpp/sdk/fizz would become cpp/sdk/fizz currently. as well as /cpp////sdk/fizz becoming cpp/sdk/fizz. This introduces a SDK configuration level option to keep delimiters when constructing URIs. THIS WILL BE OFF BY DEFAULT FOR BACKWARD COMPATIBILITY. By enabling this configuration the SDK will be aligned with other SDKs and the CLI on key paths.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl force-pushed the preserve-path-seperators branch 3 times, most recently from efc70bd to ef627d6 Compare March 26, 2024 20:48
@sbiscigl sbiscigl force-pushed the preserve-path-seperators branch 5 times, most recently from e18465b to 07789c6 Compare March 27, 2024 15:33
@sbiscigl sbiscigl marked this pull request as ready for review March 27, 2024 20:27
@sbiscigl sbiscigl merged commit 1a0db27 into main Mar 27, 2024
3 of 4 checks passed
@sbiscigl sbiscigl deleted the preserve-path-seperators branch March 27, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants