add configuration to preserve path seperator in URIs #2891
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently the C++ SDK sanitizes/normalizes uri paths that prevents us from interacting with other SDKs S3 keys. for example a S3 object with the key
///cpp/sdk/fizz
would becomecpp/sdk/fizz
currently. as well as/cpp////sdk/fizz
becomingcpp/sdk/fizz
. This introduces a SDK configuration level option to keep delimiters when constructing URIs. THIS WILL BE OFF BY DEFAULT FOR BACKWARD COMPATIBILITY. By enabling this configuration the SDK will be aligned with other SDKs and the CLI on key paths.Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.