Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rare memory leak in XML Error copy-assignment #2905

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

SergeyRyabinin
Copy link
Contributor

@SergeyRyabinin SergeyRyabinin commented Mar 25, 2024

Issue #, if available:
rare memory leak in such conditions:

    AWSError<CoreErrors> error = awsErrorMarshaller.Marshall(*BuildHttpXmlResponse("IncompleteSignatureException", message, requestId, IllFormed));
    AWSError<CoreErrors> emptyError;
    error = emptyError; // i.e. assign empty AWSError to a non-empty XML AWSError

Description of changes:
add Aws::Delete to

XmlDocument& XmlDocument::operator=(const XmlDocument& other)
<...>
Aws::Delete(m_doc);

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@@ -193,6 +196,7 @@ XmlDocument& XmlDocument::operator=(const XmlDocument& other)
if (m_doc != nullptr)
{
m_doc->Clear();
Aws::Delete(m_doc);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was missing, the rest are just nitty decorations.

@SergeyRyabinin SergeyRyabinin marked this pull request as ready for review March 25, 2024 21:45
@SergeyRyabinin SergeyRyabinin merged commit 832ce62 into main Mar 25, 2024
4 checks passed
@SergeyRyabinin SergeyRyabinin deleted the sr/rawXmlErrorMemLeak branch March 25, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants