Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix s3 flex checksums for bad memory access #2916

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

sbiscigl
Copy link
Contributor

Description of changes:

Currently our S3 integration tests will emit a valgrind warning for using unitialized memory when using a "bad" pre-calculated checksum that is not of Base64 format. When you execute the code

const auto badDecoded = HashingUtils::Base64Decode("If he came back and wanted you?");
const auto encodedAgain = HashingUtils::Base64Encode(badDecoded);

you will get a valgrind warning. This is due to a bug in our base64 implementation. I fix this in this case by using the CRT implementation of Base64 that fixes this issue. Going forward it would be recommended to use the CRT implentation and not the SDK implementation.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • Checked if this PR is a breaking (APIs have been changed) change.
  • Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl marked this pull request as ready for review April 10, 2024 17:38
@sbiscigl sbiscigl merged commit 4e93e86 into main Apr 10, 2024
4 checks passed
@sbiscigl sbiscigl deleted the checksum-valgrind branch April 10, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants